FIX: Set retain_collection_types to True (#22)

omar-rifai · pre-commit-ci[bot] · web-flow · commit 2ca56bdfe0fe · 2022-10-19T06:42:30.000-04:00
* Set retain_collection_types to True * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add unittest * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
diff --git a/pydra/tasks/nipype1/tests/test_nipype1task.py b/pydra/tasks/nipype1/tests/test_nipype1task.py
@@ -3,6 +3,8 @@
 from pkg_resources import resource_filename
 
 from nipype.interfaces import fsl
+import nipype.interfaces.utility as nutil
+
 from pydra.tasks.nipype1.utils import Nipype1Task
 
 
@@ -21,3 +23,19 @@ def test_isolation(tmp_path):
     res = slicer()
     assert res.output.out_files
     assert all(fname.startswith(str(out_dir)) for fname in res.output.out_files)
+
+
+def test_preserve_input_types():
+    def with_tuple(in_param: tuple):
+        out_param = in_param
+        return out_param
+
+    tuple_interface = nutil.Function(
+        input_names=["in_param"], output_names=["out_param"], function=with_tuple
+    )
+
+    nipype1_task_tuple = Nipype1Task(interface=tuple_interface, in_param=tuple(["test"]))
+
+    nipype1_task_tuple()
+
+    assert isinstance(nipype1_task_tuple._interface._list_outputs()["out_param"], tuple)
diff --git a/pydra/tasks/nipype1/utils.py b/pydra/tasks/nipype1/utils.py
@@ -67,7 +67,9 @@ def __init__(
         self.output_spec = traitedspec_to_specinfo(interface._outputs())
 
     def _run_task(self):
-        inputs = attr.asdict(self.inputs, filter=lambda a, v: v is not attr.NOTHING)
+        inputs = attr.asdict(
+            self.inputs, filter=lambda a, v: v is not attr.NOTHING, retain_collection_types=True
+        )
         node = nipype.Node(self._interface, base_dir=self.output_dir, name=self.name)
         node.inputs.trait_set(**inputs)
         res = node.run()
