Set retain_collection_types to True #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
=======================================
Coverage 95.83% 95.83%
=======================================
Files 2 2
Lines 24 24
Branches 4 4
=======================================
Hits 23 23
Partials 1 1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Any chance of a test that can make sure we don't lose this? |
…o fix_keep_original_datatypes
for more information, see https://pre-commit.ci
Would something of the sort work? The assert seems a bit hacky, I don't know if that's the correct way to fetch the output. |
|
Hi @effigies, is there any chance we can merge and release this? |
|
Thanks, forgot about this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents
attrs.asdict()to change the type of the inputs fromsetortupletolist. The default behavior is problematic in the case ofspmSegmentationfor example where the inputtissueshas to be atupleoftuples