style(components): don't self close tags

brandyscarney · brandyscarney · commit fcb45d12e28d · 2018-09-12T11:38:20.000-04:00
diff --git a/core/src/components/alert/alert.tsx b/core/src/components/alert/alert.tsx
@@ -337,7 +337,7 @@ export class Alert implements OverlayInterface {
                 {i.label}
               </div>
             </div>
-            {this.mode === 'md' && <ion-ripple-effect />}
+            {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
           </button>
         ))}
       </div>
@@ -368,7 +368,7 @@ export class Alert implements OverlayInterface {
                 {i.label}
               </div>
             </div>
-            {this.mode === 'md' && <ion-ripple-effect />}
+            {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
           </button>
         ))}
       </div>
diff --git a/core/src/components/button/button.tsx b/core/src/components/button/button.tsx
@@ -186,7 +186,7 @@ export class Button {
           <slot></slot>
           <slot name="end"></slot>
         </span>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/chip-button/chip-button.tsx b/core/src/components/chip-button/chip-button.tsx
@@ -63,7 +63,7 @@ export class ChipButton {
         <span class="chip-button-inner">
           <slot></slot>
         </span>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/datetime/datetime.tsx b/core/src/components/datetime/datetime.tsx
@@ -538,7 +538,7 @@ export class Datetime {
         onClick={this.open.bind(this)}
         class="datetime-cover"
       >
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/item/item.tsx b/core/src/components/item/item.tsx
@@ -161,7 +161,7 @@ export class Item {
           {showDetail && <ion-icon icon={detailIcon} lazy={false} class="item-detail-icon"></ion-icon>}
         </div>
         {state && <div class="item-state"></div>}
-        {clickable && mode === 'md' && <ion-ripple-effect />}
+        {clickable && mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </TagType>
     );
   }
diff --git a/core/src/components/segment-button/segment-button.tsx b/core/src/components/segment-button/segment-button.tsx
@@ -76,7 +76,7 @@ export class SegmentButton {
         onClick={() => this.checked = true}
       >
         <slot></slot>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/select/select.tsx b/core/src/components/select/select.tsx
@@ -506,7 +506,7 @@ export class Select {
         class="select-cover"
       >
         <slot></slot>
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </button>
     ];
   }
diff --git a/core/src/components/tabbar/tabbar.tsx b/core/src/components/tabbar/tabbar.tsx
@@ -136,7 +136,7 @@ export class Tabbar {
         {icon && <ion-icon class="tab-btn-icon" icon={icon} lazy={false}></ion-icon>}
         {label && <span class="tab-btn-text">{label}</span>}
         {badge && <ion-badge class="tab-btn-badge" color={badgeColor}>{badge}</ion-badge>}
-        {this.mode === 'md' && <ion-ripple-effect />}
+        {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}
       </a>
     );
   }
diff --git a/core/src/css/global.bundle.scss b/core/src/css/global.bundle.scss
diff --git a/core/src/utils/tap-click.ts b/core/src/utils/tap-click.ts
@@ -77,7 +77,7 @@ export function startTapClick(doc: Document) {
 
     const { x, y } = pointerCoord(ev);
 
-    // unactivate selected
+    // deactivate selected
     if (activatableEle) {
       if (clearDefers.has(activatableEle)) {
         throw new Error('internal error');

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ export class Button {`
`186`	`186`	`<slot></slot>`
`187`	`187`	`<slot name="end"></slot>`
`188`	`188`	`</span>`
`189`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`189`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`190`	`190`	`</TagType>`
`191`	`191`	`);`
`192`	`192`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ export class ChipButton {`
`63`	`63`	`<span class="chip-button-inner">`
`64`	`64`	`<slot></slot>`
`65`	`65`	`</span>`
`66`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`66`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`67`	`67`	`</TagType>`
`68`	`68`	`);`
`69`	`69`	`}`
Original file line number	Diff line number	Diff line change
`@@ -538,7 +538,7 @@ export class Datetime {`
`538`	`538`	`onClick={this.open.bind(this)}`
`539`	`539`	`class="datetime-cover"`
`540`	`540`	`>`
`541`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`541`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`542`	`542`	`</button>`
`543`	`543`	`];`
`544`	`544`	`}`
Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ export class Item {`
`161`	`161`	`{showDetail && <ion-icon icon={detailIcon} lazy={false} class="item-detail-icon"></ion-icon>}`
`162`	`162`	`</div>`
`163`	`163`	`{state && <div class="item-state"></div>}`
`164`		`- {clickable && mode === 'md' && <ion-ripple-effect />}`
	`164`	`+ {clickable && mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`165`	`165`	`</TagType>`
`166`	`166`	`);`
`167`	`167`	`}`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ export class SegmentButton {`
`76`	`76`	`onClick={() => this.checked = true}`
`77`	`77`	`>`
`78`	`78`	`<slot></slot>`
`79`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`79`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`80`	`80`	`</button>`
`81`	`81`	`];`
`82`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,7 @@ export class Select {`
`506`	`506`	`class="select-cover"`
`507`	`507`	`>`
`508`	`508`	`<slot></slot>`
`509`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`509`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`510`	`510`	`</button>`
`511`	`511`	`];`
`512`	`512`	`}`
Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ export class Tabbar {`
`136`	`136`	`{icon && <ion-icon class="tab-btn-icon" icon={icon} lazy={false}></ion-icon>}`
`137`	`137`	`{label && <span class="tab-btn-text">{label}</span>}`
`138`	`138`	`{badge && <ion-badge class="tab-btn-badge" color={badgeColor}>{badge}</ion-badge>}`
`139`		`- {this.mode === 'md' && <ion-ripple-effect />}`
	`139`	`+ {this.mode === 'md' && <ion-ripple-effect></ion-ripple-effect>}`
`140`	`140`	`</a>`
`141`	`141`	`);`
`142`	`142`	`}`