Skip to content

Commit 6c6dca3

Browse files
authored
Merge pull request github#21152 from codewithdev/codewithdev-20631
Added exceptional subdomains in the redirect URLs
2 parents 392734f + 6381c27 commit 6c6dca3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,14 +283,16 @@ you or your users have two-factor authentication enabled.
283283

284284
The `redirect_uri` parameter is optional. If left out, GitHub will
285285
redirect users to the callback URL configured in the OAuth Application
286-
settings. If provided, the redirect URL's host and port must exactly
286+
settings. If provided, the redirect URL's host (excluding sub-domains) and port must exactly
287287
match the callback URL. The redirect URL's path must reference a
288288
subdirectory of the callback URL.
289289

290290
CALLBACK: http://example.com/path
291291

292292
GOOD: http://example.com/path
293293
GOOD: http://example.com/path/subdir/other
294+
GOOD: http://oauth.example.com/path
295+
GOOD: http://oauth.example.com/path/subdir/other
294296
BAD: http://example.com/bar
295297
BAD: http://example.com/
296298
BAD: http://example.com:8080/path

0 commit comments

Comments
 (0)