Skip to content

Added exceptional subdomains in the redirect URLs #21152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 10, 2022
Merged

Added exceptional subdomains in the redirect URLs #21152

merged 5 commits into from
Oct 10, 2022

Conversation

codewithdev
Copy link
Contributor

Why:

Closes #20631

What's being changed (if available, include any code snippets, screenshots, or gifs):

  • Added the following exceptions to the redirect URLs:
    http://oauth.example.com/path
    http://oauth.example.com/path/subdir/other

  • Changed the leading sentence that talks about the redirect URL's host and callback URLs.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 6, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
developers/apps/building-oauth-apps/authorizing-oauth-apps.md fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae
 fpt
ghec
ghes@ 3.6 3.5 3.4 3.3 3.2
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@steveward steveward added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review developers Content related to developers and removed triage Do not begin working on this issue until triaged by the team labels Oct 7, 2022
@steveward
Copy link
Member

Thanks for the pull request @codewithdev! I'll get this triaged for review.

am-stead
am-stead approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@am-stead am-stead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR and improving our docs!💖
I've approved the changes. I've just added a space on line 286 here.
I'll get this merged for you! 🚀

@am-stead am-stead enabled auto-merge October 10, 2022 14:56
@cmwilson21 cmwilson21 added the ready to merge This pull request is ready to merge label Oct 10, 2022
@am-stead am-stead merged commit 6c6dca3 into github:main Oct 10, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@cmwilson21 cmwilson21 added hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! and removed ready to merge This pull request is ready to merge labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@am-stead am-stead am-stead approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team developers Content related to developers hacktoberfest-accepted We might not merge this PR before Nov 1st, but it's a wonderful Hacktoberfest contribution! waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oauth redirect_uri documents a Host constraint that doesn't exist
4 participants
@codewithdev @steveward @am-stead @cmwilson21