Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered while investigating #8535 (comment).
I noticed that not all deps of a failed optional dep were added to the trash list.
I modified the tests to expose this and changed the implementation to fix it.
Best illustrated with this graph showing the results of the test case
const setO = optionalSet(nodeO)
:Yellow nodes were returned by the prev implementation. Yellow + green nodes are returned by the fixed implementation.
Code to produce graph