Skip to content

MAINT: Convert dummymodule to multi-phase init (PEP 489) #29026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

MAINT: Convert dummymodule to multi-phase init (PEP 489) #29026

merged 1 commit into from
May 28, 2025

Conversation

AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented May 21, 2025 •
edited
Loading

@AA-Turner AA-Turner mentioned this pull request May 21, 2025
Open
@AA-Turner AA-Turner force-pushed the multi-phase/dummymodule branch from 0874fb5 to a9c14b8 Compare May 22, 2025 02:54
@AA-Turner AA-Turner marked this pull request as draft May 24, 2025 06:22
@AA-Turner AA-Turner force-pushed the multi-phase/dummymodule branch from a9c14b8 to 8193862 Compare May 28, 2025 11:08
@AA-Turner AA-Turner marked this pull request as ready for review May 28, 2025 12:28
@AA-Turner
Copy link
Contributor Author

cc @seberg

@seberg
Copy link
Member

seberg commented May 28, 2025

LGTM, thanks.

@seberg seberg changed the title GH-29021: Convert dummymodule to multi-phase init (PEP 489) MAINT: Convert dummymodule to multi-phase init (PEP 489) May 28, 2025
@seberg seberg merged commit 7ae80cd into numpy:main May 28, 2025
74 checks passed
@AA-Turner AA-Turner deleted the multi-phase/dummymodule branch May 28, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AA-Turner @seberg