MAINT: Convert pocketfft_umath to multi-phase init (PEP 489) #29028
Conversation
074fb12 to
14b4169
Compare
14b4169 to
92b2cca
Compare
|
cc @seberg. We prevent multiple inits because the static function and type arrays are used in the A |
92b2cca to
322d761
Compare
There was a problem hiding this comment.
Looks fine with the decref fixed.
FWIW, while I think it's likely a bad idea to create these ufuncs multiple times, I don't actually think it's a problem and this module is actually safe to delete and reload.
(Not saying it will actually get all cleaned up, I would be surprised, but for the most part.)
Sorry for that, remnants of experimentation. |
Fair enough, I admit I haven't tried. I think keeping this PR as-is and looking to relax the restriction in a followup may be prudent, though? |
| NULL, /* m_doc */ | ||
| 0, /* m_size */ | ||
| NULL, /* m_methods */ | ||
| _pocketfft_umath_slots, /* m_slots */ |
There was a problem hiding this comment.
Now that I scroll through, I would have liked to use .m_base = , etc. but a cleanup for another day.
There was a problem hiding this comment.
Designated initialisers are only supported for C++20 -- hence the legacy style.
A
Uh oh!
There was an error while loading. Please reload this page.