MAINT: Fix for segfaults with GCC 15 #29132
Merged
+4
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 15 generates code that segfaults on newer hardware when running tests. See numpygh-28991 for details. A fix is to always require alignment, which can be done by setting `NPY_ALIGNMENT_REQUIRED = 1`. We retain `NPY_ALIGNMENT_REQUIRED` here for downstream compatibility in the 2.3.x release series, but do remove its use in our own code. The associated macro `NPY_USE_UNALIGNED_ACCESS` could also be removed as it is always 0, but that is left for another PR.
Mousius
approved these changes
Jun 5, 2025
|
I'm impressed that you hit three different CI heisenbugs 😄 |
I thought it pretty wonderful myself :) |
|
Can you merge this branch into |
OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 15 generates code that segfaults on newer hardware when running tests. See gh-28991 for details. A fix is to always require alignment, which can be done by setting
NPY_ALIGNMENT_REQUIRED = 1.We retain
NPY_ALIGNMENT_REQUIREDhere for downstream compatibility in the 2.3.x release series, but do remove its use in our own code. The associated macroNPY_USE_UNALIGNED_ACCESScould also be removed as it is always 0, but that is left for another PR.This is a stripped down version of #29094.