TYP: Simplified dtype.__new__ overloads
#29168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the number of overloads from 65 to 40. Overloads are very computationally expensive to typecheck, because all combinations of overloads have to be considered. I haven't tested it myself, but I wouldn't be surprised if this change reduces the average runtimes of the mypy's and the pyright's by a couple of seconds.
Most of the "removed" overloads were merged into another the same return type. Some others for abstract scalar-types like
flexibleandgenericwere also removed, because I doubt that they will ever be used in realistic use-cases. And I figured that the primer will tell us if that assumption is false.