strides comparison performance fix, compare discussion #29179 #29188
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did any benchmarks change? |
|
There are no benchmarks for this yet. However, I will modify the one I created last time so we get some numbers on that, too as soon as I have a free moment. |
|
Might be nice to see a small change in benchmarks. But if it doesn't change much at all, I don't mind. It's just better to use the correct logic either way, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #29179, here a strides comparison performance fix: negative strides were not accounted for which could have led to lower-than-otherwise-possible performance. Now absolute stride values are considered instead.