BUG: add support for NaT (Not-a-Time) handling in nummpy.sign ufunc. #29506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I propose that we close this one in favor of gh-29498, since the other PR came first and already has a regression test. The patches are small enough that it shouldn't be too much of an inconvenience in any case. |
I am really sorry for this, since this was my first ever contribution in open-source, i was unaware about the PR you already raised for the same issue. Hope you understand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG FIX : #29496
Added the support for handling special NaT values in
np.sign(), for consistency with the behavior of the inexact types. Earliernp.sign(np.timedelta64('nat'))was returningtimedelta64(-1)and for consistency with the behavior of the inexact types (e.g.np.sign(np.nan)returnsnp.float64(nan)), it should returntimedelta64('nat'). After committing this change, it successfully returnstimedelta64('nat')onnp.timedelta64('nat')inputs.Previously :
After this fix :
This change aligns the behavior with expectations for inexact types and addresses issue #29496.