I prefer to play loose and free with either single- or double- quotes, but will play along if that is the community decision. It seems a bit disruptive to reformat everything though.

I'm all for enforcing this, but I can imagine that this 348 file diff could cause merge conflicts in many of the open PR's. So maybe we can limit this to e.g. .pyi or certain directories for now?

Sure, point taken, thanks - I've updated so it only applies to the .pyi files

I prefer to play loose and free with either single- or double- quotes

Out of curiosity; any particular reason for that?

Out of curiosity; any particular reason for that?

Double quotes are harder to type (two key presses) and somehow visually heavier and less appealing. So I usually use single quotes when it is a single word or character and double quotes when I truly want to make a statement.

Double quotes are harder to type (two key presses) and somehow visually heavier and less appealing. So I usually use single quotes when it is a single word or character and double quotes when I truly want to make a statement.

Yea I guess that makes sense. I'm also fine with using ' quotes everywhere. I suppose that enforcing one or the other is more about consistency, which can help reduce diff sizes, and avoids you from having to think about which one to use. So theoretically it doesn't matter which one we choose.

But note that the " choice is a lot more common (in my experience), probably because of black. So for those used to the black style (like me), the chance of accidentally using the wrong quotes is higher if we go with the less common ', which could lead to more CI usage. But who knows, perhaps that won't even be noticeable in practice 🤷🏻.

I have a slight preference for single quotes, but have been trying to move to double quotes because of Black. That said, it is easy enough to run ruff to fix things up.

it is easy enough to run ruff to fix things up

Yes, every project I contribute to has some expectation that you'll run make lint or spin lint or pre-commit run -a or some other command that does these automated things.

In other projects I just type single quotes (as @mattip observed, they're easier to type) and then let the auto-formatter sort them out according to the project's preferences

I'd appreciate it if this rule could at least be enabled for the stubs anyway, so that quotes can be consistent and neither reviewers nor contributors need think about them 🙏

Seems like we can just put this in? FWIW, would be nice to add the ruff rule, but not usre how easy it is just for the stubs.
(I don't mind just doing more/full auto-formatting, we break all PRs once of course, although you could probably ruff --fix and then merge most.)

Thanks!

but not usre how easy it is just for the stubs.

That's what this PR does, it enables the rule just for the stubs 😄 Check the changes to ruff.toml

And in it goes; thanks Marco :)

Hah sorrysomehow I looked and missed the toml changes...