BUG: SIMD Neon undefined behavior - pointer overflow #29549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simd/neon/memory.h
by adding bounds checking on stride size - (related to BUG: resolve undefined behavior issues currently suppressed by UBSAN CI #29524)avx2/memory.h
(also inavx512
)While looking at other architecture options for the same function
npyv_loadn_u32
, I noticed thatsse
,lsx
,vec
do not have a bounds check on the stride, but were not flagged by UBSAN (they all use array indexing instead of pointer arithmetic). For example forsse/memory.h
L79:Should these other implementations also include bounds checks?