-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
DOC: Document datetime and timedelta to python's object type conversion #29557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devmt04
wants to merge
5
commits into
numpy:main
Choose a base branch
from
devmt04:docs-datetime-pyobject-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+26
−5
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f478f98
DOC: document datetime/timedelta to PyObject conversion
devmt04 7acb9dc
Merge branch 'numpy:main' into docs-datetime-pyobject-conversion
devmt04 78e201c
DOC: document datetime/timedelta to PyObject conversion
devmt04 21e460e
DOC: document datetime/timedelta to PyObject conversion
devmt04 9ad8aa1
Merge branch 'numpy:main' into docs-datetime-pyobject-conversion
devmt04 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be easier to read and digest this as a table. I'd also like to see some code examples to explicitly show what happens. The nice part about code examples is they get run as part of our test suite.
Instead of "Not-a-time" I think we usually refer to it as
NaT
.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think also adding some text this page explaining what NaT is would be helpful. We use it in a few places above, but we never explicitly explain it's the datetime equivalent of NaN and that NaT is short for not-a-time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should explain NaT explicitly under title "Datetime units", as we already had given an overview of it under "Basic datetimes".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I have noticed a unknown non-linear timedelta type "B" mentioned in C code comments, is that a thing in NumPy? As I found no reference of it in docs.
All I am aware of is that "B" is one of the Period aliases in Pandas. Is this a mistake?