TYP: fix np.bool method declarations
#29695
Merged
+194
−117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially addresses the incorrect way that we've been defining the methods of scalar types. Currently, this accidentally woirks in mypy, but there are good reasons for why it shouldn't. But as it currently stands, mypy can't address this, because that would cause problems for many libraries that use numpy.
Unless mypy_primer complains, then I'd like to backjport this, so that mypy doesn't have to wait ~5 months or so.
See python/mypy#15993 (comment) for context.
Note that the integer and floating scalar-type also have this issue. I'll address those in separate PR's (this weekend, hopefully).