BLD: check that we're building a tag before PyPI upload #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be redundant given that the environment requires a final manual step for deployment to pypi |
rgommers
reviewed
Aug 10, 2025
There was a problem hiding this comment.
This might be redundant given that the environment requires a final manual step for deployment to pypi
I think it is indeed. It can't really hurt either, but it'd be hard to get this wrong as release manager in both the release process and then the manual step at the end. Wheel names will also contain .dev0 if it isn't a release tag.
I'll leave the decision up to you - I'm okay with merging this if you think it is useful.
I think putting this in would give more confidence for now that things are correct |
|
All right, in it goes then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.