fix: fuzzy autocompletion with blink #1010
Conversation
9504c22 to
4cad01e
Compare
4cad01e to
1403ced
Compare
|
@kristijanhusak The PR is open quite a while. Any feedback what is preventing the merge? The failing test is unrealted to the code. I just rebased it onto the latest master. |
There was a problem hiding this comment.
Sorry for the delay. I didn't get a chance to do a proper review and testing.
This does solve some of the issues with the fuzzy matching, but it introduces some other bugs. For example, autocompletion by headline/custom id after the file name stopped working:
[[file:/path/to/org/todos.org::*My headline
This simplified base is a bit hacky tbh. Can we figure out a solution where the fuzzy matching would work for all the sources? For example, add fuzzy = true/false to the org.completion.complete function in a same way that you added framework, and set true from cmp/blink, and for omni, check if &competeopt has it.
Then, if it's true, use matchfuzzy to match the values, otherwise do the substring as it is now.
What do you think?
|
Unfortunately it's not that simple. The substring matching goes all the way down to the sources. It needs to be refactored so the context can be passed down, and internal sources can rely on the context value. I'll see if I can figure out something out at least for testing. |
Summary
This PR fixes fuzzy matching for blink.cmp in orgmode completion. Previously blink.cmp only did prefix matching like nvim-cmp, now it
actually uses its fuzzy matcher.
Related Issues
Related #977
Changes
filterTextfield so blink.cmp knows what to fuzzy match againstChecklist
I confirm that I have:
Conventional Commits
specification (e.g.,
feat: add new feature,fix: correct bug,docs: update documentation).make test.