-
Notifications
You must be signed in to change notification settings - Fork 10k
[IMP] Payroll: Updating payslips #14425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
f387175
to
42b8759
Compare
Hi @Felicious - this is ready for a peer/final/tech review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @larm-odoo ! I got blocked while reviewing 🙈 I couldn't find where to find a draft payslip. Could you point it out to me, so I can continue the review and add suggestions to make sure the reader always knows which page they're supposed to be on to make the configuration? (:
**required** Once a selection is made, other fields may auto-populate according to the employee | ||
record. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add period (required)
- suggestion for brevity (not required!)
**required** Once a selection is made, other fields may auto-populate according to the employee | |
record. | |
**required**. Fields may auto-populate based on the employee record once a selection is made. |
Once everything on the payslip form is correct, click the :guilabel:`Create Draft Entry` button to | ||
create the payslip. A :guilabel:`Confirmation` pop-up window appears, asking :guilabel:`Are you sure | ||
you want to proceed?` Click :guilabel:`OK` to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what page I'm supposed to be at to find a completed payslip to process 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh... I see. So everythign shoudl go in the order, from top of the document to the bottom. So you are still on the new payslip you created.
So you click NEW on the All Payslips or Payslips to Pay dashboards (they all do the same thing).
Once you select an employee (they have to have a contract!), the Worked Days & Unputs tab populates.
You click Compute Sheet at the top (this does the calculations of the worked days according to the salary).

After that, the Compute Sheet button changed to the Create Draft Entry button:
I think that should do it! Remember if there's ay conflicts, things wont't work- so if they don't have a ocntractm youc an't ocmpute the sheet, etc.
Warnings are grouped by type, such as `Employees Without Running Contracts` or `Employees Without | ||
Bank account Number`. Click on a warning to view all entries associated with that specific issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not very important of an edit but i think because these warnings appear on the UI and the user doesn't type them, these should be guilabels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Felicious - I answered your question in the comments!
Once everything on the payslip form is correct, click the :guilabel:`Create Draft Entry` button to | ||
create the payslip. A :guilabel:`Confirmation` pop-up window appears, asking :guilabel:`Are you sure | ||
you want to proceed?` Click :guilabel:`OK` to confirm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh... I see. So everythign shoudl go in the order, from top of the document to the bottom. So you are still on the new payslip you created.
So you click NEW on the All Payslips or Payslips to Pay dashboards (they all do the same thing).
Once you select an employee (they have to have a contract!), the Worked Days & Unputs tab populates.
You click Compute Sheet at the top (this does the calculations of the worked days according to the salary).

After that, the Compute Sheet button changed to the Create Draft Entry button:
I think that should do it! Remember if there's ay conflicts, things wont't work- so if they don't have a ocntractm youc an't ocmpute the sheet, etc.
Reworking and reorganizing entire doc based on new logic (the flow for the payslip process). Batches and commissions are pulled out, so this ONLY focuses on individual apyslips, and the payslips menu. Also updating to new standards, redoing all images, adding more clarity.
Note- Batches and Commission payslips are both on new, indiviual PR's. I know when I merge them all, I will have to fix conflicts!
Original task card for this PR.