Skip to content

Conversation

larm-odoo
Copy link
Contributor

@larm-odoo larm-odoo commented Aug 27, 2025

Reworking and reorganizing entire doc based on new logic (the flow for the payslip process). Batches and commissions are pulled out, so this ONLY focuses on individual apyslips, and the payslips menu. Also updating to new standards, redoing all images, adding more clarity.

Note- Batches and Commission payslips are both on new, indiviual PR's. I know when I merge them all, I will have to fix conflicts!

Original task card for this PR.

@robodoo
Copy link
Collaborator

robodoo commented Aug 27, 2025

Pull request status dashboard

@larm-odoo larm-odoo self-assigned this Aug 27, 2025
@larm-odoo larm-odoo added the 3 label Aug 27, 2025
@C3POdoo C3POdoo requested a review from a team August 27, 2025 15:13
@larm-odoo larm-odoo marked this pull request as draft August 27, 2025 15:15
@larm-odoo larm-odoo force-pushed the 18.0-payroll-update-payslips-larm branch from f387175 to 42b8759 Compare August 28, 2025 20:39
@larm-odoo larm-odoo marked this pull request as ready for review August 28, 2025 20:39
@larm-odoo larm-odoo added 5 and removed 3 labels Aug 28, 2025
@larm-odoo larm-odoo requested a review from Felicious August 28, 2025 20:39
@larm-odoo
Copy link
Contributor Author

Hi @Felicious - this is ready for a peer/final/tech review!

Copy link
Contributor

@Felicious Felicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @larm-odoo ! I got blocked while reviewing 🙈 I couldn't find where to find a draft payslip. Could you point it out to me, so I can continue the review and add suggestions to make sure the reader always knows which page they're supposed to be on to make the configuration? (:

Comment on lines +28 to +29
**required** Once a selection is made, other fields may auto-populate according to the employee
record.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add period (required)
  • suggestion for brevity (not required!)
Suggested change
**required** Once a selection is made, other fields may auto-populate according to the employee
record.
**required**. Fields may auto-populate based on the employee record once a selection is made.

Comment on lines +184 to +186
Once everything on the payslip form is correct, click the :guilabel:`Create Draft Entry` button to
create the payslip. A :guilabel:`Confirmation` pop-up window appears, asking :guilabel:`Are you sure
you want to proceed?` Click :guilabel:`OK` to confirm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what page I'm supposed to be at to find a completed payslip to process 😢

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh... I see. So everythign shoudl go in the order, from top of the document to the bottom. So you are still on the new payslip you created.

So you click NEW on the All Payslips or Payslips to Pay dashboards (they all do the same thing).

Once you select an employee (they have to have a contract!), the Worked Days & Unputs tab populates.

You click Compute Sheet at the top (this does the calculations of the worked days according to the salary).

image

After that, the Compute Sheet button changed to the Create Draft Entry button:
image

I think that should do it! Remember if there's ay conflicts, things wont't work- so if they don't have a ocntractm youc an't ocmpute the sheet, etc.

Comment on lines 172 to 173
Warnings are grouped by type, such as `Employees Without Running Contracts` or `Employees Without
Bank account Number`. Click on a warning to view all entries associated with that specific issue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very important of an edit but i think because these warnings appear on the UI and the user doesn't type them, these should be guilabels

@Felicious Felicious self-requested a review August 28, 2025 22:46
Copy link
Contributor Author

@larm-odoo larm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Felicious - I answered your question in the comments!

Comment on lines +184 to +186
Once everything on the payslip form is correct, click the :guilabel:`Create Draft Entry` button to
create the payslip. A :guilabel:`Confirmation` pop-up window appears, asking :guilabel:`Are you sure
you want to proceed?` Click :guilabel:`OK` to confirm.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh... I see. So everythign shoudl go in the order, from top of the document to the bottom. So you are still on the new payslip you created.

So you click NEW on the All Payslips or Payslips to Pay dashboards (they all do the same thing).

Once you select an employee (they have to have a contract!), the Worked Days & Unputs tab populates.

You click Compute Sheet at the top (this does the calculations of the worked days according to the salary).

image

After that, the Compute Sheet button changed to the Create Draft Entry button:
image

I think that should do it! Remember if there's ay conflicts, things wont't work- so if they don't have a ocntractm youc an't ocmpute the sheet, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants