feat: add support for OCI repository pattern for add component version #628
+572
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1fbd25 to
817f238
Compare
Skarlso
commented
Aug 26, 2025
e29110b to
c28c8f5
Compare
c28c8f5 to
106aaed
Compare
Skarlso
commented
Aug 27, 2025
4b1523f to
e5b249f
Compare
Skarlso
commented
Aug 28, 2025
| addCMD.SetArgs([]string{ | ||
| "add", | ||
| "component-version", | ||
| "--repository", fmt.Sprintf("http://%s", registryAddress), |
There was a problem hiding this comment.
@jakobmoellerdev The "fix" to my above credential issue was adding http:// here before the repository address. 🤔 Is that correct or should it have worked without the scheme?
|
Ugh, the tests together are not working of course. I need a way to isolate them. |
|
Yay, the tests are passing. I'm going to overhaul the suite_test a bit. |
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
…rsing On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
3db798e to
476c932
Compare
fabianburth
reviewed
Aug 29, 2025
| @@ -106,7 +107,7 @@ add component-version --%[1]s ./path/to/%[2]s --%[3]s ./path/to/%[4]s.yaml | |||
| } | |||
|
|
|||
| cmd.Flags().Int(FlagConcurrencyLimit, 4, "maximum number of component versions that can be constructed concurrently.") | |||
| file.VarP(cmd.Flags(), FlagRepositoryRef, string(FlagRepositoryRef[0]), LegacyDefaultArchiveName, "path to the repository") | |||
| cmd.Flags().StringP(FlagRepositoryRef, string(FlagRepositoryRef[0]), LegacyDefaultArchiveName, "repository specification") | |||
There was a problem hiding this comment.
It is not actually a repository specification, is it?
There was a problem hiding this comment.
It's a repository url I guess?
There was a problem hiding this comment.
Also can be sort a specification because it's no longer "just a path". What could we call this?
| func TestParseRepository(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| repoSpec string |
There was a problem hiding this comment.
It might be kind of a nit, but I think it's generally a bit misleading that you call this repoSpec, as a repo spec is a established term in ocm and that's not it.
There was a problem hiding this comment.
Hm, we actually call this repoSpec in the Parser that gets it. 🤔 From the Ref we do:
for _, prefix := range ValidPrefixes {
token := "/" + prefix + "/"
if idx := strings.LastIndex(input, token); idx != -1 {
repoSpec := input[:idx]On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
On-behalf-of: Gergely Brautigam <gergely.brautigam@sap.com> Signed-off-by: Gergely Brautigam <182850+Skarlso@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Fixes open-component-model/ocm-project#578
Which issue(s) this PR fixes