-
Notifications
You must be signed in to change notification settings - Fork 736
docs: add missing tests for getting started examples #4662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts. - test_metrics.py: Validates all 7 metric types with specific expected values - test_otlpcollector.py: Tests OTLP collector example with graceful timeout handling Fixes open-telemetry#4001
I think the issue was about running examples code in CI and not about writing some new tests |
My bad! 😄 i'll update! |
@xrmx - I do see that the existing tests run as part of CI. Example run from another PR that's open: https://github.com/open-telemetry/opentelemetry-python/actions/runs/15904348585/job/44855076756?pr=4659 Is there more to be done to add these tests to the CI pipeline? I see that they are configured here 🤔 |
@xrmx just checking in again - can you help clarify the requirements? |
@sginji please fix the lint errors and setup pre-commit and we should be good to go. |
f5442cb
to
f249def
Compare
3378d99
to
081bf0a
Compare
Description
Add test_metrics.py and test_otlpcollector.py to validate the metrics_example.py and otlpcollector_example.py scripts.
Fixes #4001
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: