Skip to content

feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0 #3685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 22, 2025
Merged

feat: Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0 #3685

merged 8 commits into from
Aug 22, 2025
+2,455 −2,450

Conversation

papigers
Copy link
Contributor

@papigers papigers commented Aug 7, 2025 •
edited
Loading

Description

Update opentelemetry-instrumentation-confluent-kafka to support confluent-kafka <=2.11.0

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

  • Ran standard existing tests through tox

Does This PR Require a Core Repo Change?

  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Documentation has been updated

@papigers papigers requested a review from a team as a code owner August 7, 2025 13:47
@papigers
Copy link
Contributor Author

Hi @oxeye-dorkolog, would appreciate your CR here 🙏

emdneto
emdneto reviewed Aug 11, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. After the fix, running tox -e generate should be enough to bring everything in sync.

@emdneto emdneto moved this to Easy to review / merge / close in @xrmx's Python PR digest Aug 11, 2025
@emdneto emdneto moved this from Easy to review / merge / close to Reviewed PR that needs fixing in @xrmx's Python PR digest Aug 11, 2025
@papigers
Copy link
Contributor Author

Thanks. After the fix, running tox -e generate should be enough to bring everything in sync.

Ran it now, didn't seem to add any new changes

emdneto
emdneto reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff locally

emdneto
emdneto reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see you've fixed all the comments, but changelog entry should be under # Unrelease section.
To fix ruff you may want to run tox -e ruff locally

@papigers
Copy link
Contributor Author

thanks @emdneto fixed now

emdneto
emdneto reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's happening with asyncclick instrumentatio, but python-trio/asyncclick#37

emdneto
emdneto reviewed Aug 14, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI issue is solved now

@emdneto emdneto moved this from Reviewed PR that needs fixing to Approved PRs in @xrmx's Python PR digest Aug 15, 2025
@xrmx xrmx enabled auto-merge (squash) August 22, 2025 15:03
@xrmx xrmx merged commit c6b14fc into open-telemetry:main Aug 22, 2025
632 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in @xrmx's Python PR digest Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
@xrmx's Python PR digest
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papigers @xrmx @emdneto