-
Notifications
You must be signed in to change notification settings - Fork 766
Update vertexai instrumentation to be in-line with the latest semantic conventions #3709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update vertexai instrumentation to be in-line with the latest semantic conventions #3709
Conversation
I'm confused by the Maybe the value of that envvar should just be a version number, and every new version which has breaking changes we put them behind a gate with that version number ? If a user sets the env var to v3, they get all breaking changes from v1/v2/v3, there will be no way to pick and choose which breaking changes they get.. But making all the permutations of breaking changes opt-in is kind of a pain.. I suppose the flag is repeated so we could let users specify multiple versions in it, to get just the breaking changes they want.. Users will be opted-in to the non-breaking semantic convention changes by default, I think that is fine.. I don't like that new users have to know to set this env var and don't get all the newest stuff by default.. I realize what I've just described doing with an env var, is the same thing that we do with the standard release.. It's kind of like we want 2 releases one with breaking changes and one without.. Would be interested in others thoughts on this.. |
Could you please check if #3280 can be closed now |
What do you want to do regarding ordering of this PR and these: |
Ideally those go in first. #3718 may take longer but it's kind of minor and I don't think it should block this one. This PR is ready for review though, I don't think we need to wait for those to review this one |
Description
Start making changes to implement the big semantic convention changes made in open-telemetry/semantic-conventions#2179.
Now only a single event (
gen_ai.client.inference.operation.details
) is used to capture Chat History. These changes will be opt-in, users will need to set the environment variable OTEL_SEMCONV_STABILITY_OPT_IN togen_ai_latest_experimental
to see them.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
No.. We should wait for a sem conv release (and core repo to pick that up) before releasing this change, but I don't this PR needs to wait for those.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.