feat: Fix #412 add optional details data to function tool execution #413
Conversation
🦋 Changeset detectedLatest commit: c287994 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
8bba4b4 to
652e302
Compare
|
Codex Review: Here are some suggestions. openai-agents-js/packages/agents-core/src/tool.ts Lines 68 to 71 in 8bba4b4 [P1] Make details parameter optional on FunctionTool.invoke
Reply with About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
| @@ -67,6 +68,7 @@ export type FunctionTool< | |||
| invoke: ( | |||
| runContext: RunContext<Context>, | |||
| input: string, | |||
| details?: { toolCall: protocol.FunctionCallItem }, | |||
There was a problem hiding this comment.
if we don't want to expose all the tool call data, I can filter this to have only callId
There was a problem hiding this comment.
having FunctionCallItem is actually great 👍
The feature request #412 is valid, so we may want to add further information to function tool execution if a developer needs. This changes do not break any existing apps.