Skip to content

Upgrade to version of generator with perf logging #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
+16 −9
Merged

Upgrade to version of generator with perf logging #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion codegen/generator/src/OpenAI.Library.Plugin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250829.4" />
<PackageReference Include="Microsoft.TypeSpec.Generator.ClientModel" Version="1.0.0-alpha.20250903.1" />
</ItemGroup>

<!-- Copy output to package dist path for local execution and -->
Expand Down
4 changes: 2 additions & 2 deletions codegen/generator/src/Visitors/ExperimentalAttributeVisitor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,8 +664,8 @@ public class ExperimentalAttributeVisitor : ScmLibraryVisitor

if (!_stableMethods.Contains(lookupName))
{
methodProvider.Update(
attributes: [.. methodProvider.Attributes,
methodProvider.Signature.Update(
attributes: [.. methodProvider.Signature.Attributes,
methodProvider.EnclosingType.Type.Namespace.StartsWith(_realtimeNamespace) || (methodProvider.Signature.ReturnType?.Namespace.StartsWith(_realtimeNamespace) ?? false) ?
_experimental002Attribute :
_experimental001Attribute]);
Expand Down
2 changes: 1 addition & 1 deletion codegen/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"@open-ai/plugin": "file:",
"@azure-tools/typespec-client-generator-core": "0.59.0",
"@azure-tools/typespec-azure-core": "0.59.0",
"@typespec/http-client-csharp": "1.0.0-alpha.20250829.4",
"@typespec/http-client-csharp": "1.0.0-alpha.20250903.1",
"@typespec/http": "1.3.0",
"@typespec/openapi": "1.3.0"
},
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion scripts/Invoke-CodeGen.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,17 @@ Push-Location $repoRootPath

try {
Invoke-ScriptWithLogging { npm ci }
if ($LASTEXITCODE -ne 0) {
exit $LASTEXITCODE
}

Invoke-ScriptWithLogging { npm run build -w $codegenFolderPath }
if ($LASTEXITCODE -ne 0) {
exit $LASTEXITCODE
}

Set-Location $specificationFolderPath
Invoke-ScriptWithLogging { npm exec --no -- tsp compile . }
Invoke-ScriptWithLogging { npx tsp compile . --trace @typespec/http-client-csharp }
}
finally {
Pop-Location
Expand Down