Skip to content

Hypershift e2e tests for OADP-1.4 #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 2, 2025
Merged

Hypershift e2e tests for OADP-1.4 #1924

merged 2 commits into from
Sep 2, 2025

Conversation

weshayutin
Copy link
Contributor

@weshayutin weshayutin commented Aug 20, 2025 •
edited
Loading

Why the changes were made

We want to run tests w/ the oadp-1.4 branch

How to test the changes made

Most of these files were copied directly from the oadp-1.5 branch
Required by: openshift/release#68289

@weshayutin weshayutin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 20, 2025
@openshift-ci openshift-ci bot requested review from eemcmullan and sseago August 20, 2025 19:40
@weshayutin
Copy link
Contributor Author 

warning: both GOPATH and GOROOT are the same directory (/opt/app-root/src/go); see https://go.dev/wiki/InstallTroubleshooting
# github.com/openshift/oadp-operator/tests/e2e/lib/hcp
lib/hcp/dpa.go:27:29: undefined: oadpv1alpha1.DefaultPluginHypershift
lib/hcp/dpa.go:39:116: undefined: oadpv1alpha1.DefaultPluginHypershift
lib/hcp/dpa.go:44:17: undefined: oadpv1alpha1.HypershiftPluginImageKey
lib/hcp/dpa.go:64:53: undefined: oadpv1alpha1.HypershiftPluginImageKey
lib/hcp/dpa.go:67:29: undefined: oadpv1alpha1.DefaultPluginHypershift
lib/hcp/dpa.go:93:29: undefined: oadpv1alpha1.DefaultPluginHypershift

This is expected until #1915 is merged.
/hold

@weshayutin weshayutin force-pushed the hcp_oadp14 branch 2 times, most recently from 64149a4 to 95c082e Compare August 26, 2025 21:03
@weshayutin
use oadp-1.5 e2e on the 1.4 branch
92624b4 
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@weshayutin
remove inappropriate dpa test for 1.4
cec4733 
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 29, 2025

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@weshayutin weshayutin changed the title DNM, Hypershift e2e tests for OADP-1.4 Hypershift e2e tests for OADP-1.4 Aug 29, 2025
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2025
@weshayutin weshayutin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2025
mpryc
mpryc reviewed Sep 2, 2025
View reviewed changes
Copy link
Contributor

@mpryc mpryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 04f9e2d into openshift:oadp-1.4 Sep 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpryc mpryc mpryc left review comments

@kaovilai kaovilai kaovilai approved these changes

@shubham-pampattiwar shubham-pampattiwar shubham-pampattiwar approved these changes

@eemcmullan eemcmullan Awaiting requested review from eemcmullan

@sseago sseago Awaiting requested review from sseago

Assignees

@mpryc mpryc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weshayutin @kaovilai @mpryc @shubham-pampattiwar