fix: create state only on resource event #2899
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general we cleanup caches on delete event, so although in practice this probably not causing issues in theory it can happen that we receive events where there is no related custom resource. In that case we would create state, what can lead to a memory leak. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
97b2f74 to
409a6ca
Compare
xstefank
approved these changes
Aug 15, 2025
|
In close future I will iterate in this probably to clean things up more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general we cleanup state on delete event, so although in practice this probably not causing
issues in theory it can happen that we receive events where there is no related custom resource.
What effectivel means a memory leak, since that state never cleaned up - again it is more theoretical than practical issues, since it practice usually events are propagated related to a custom resource (or based on that).
This PR fixes it in a way that it checks that when state is created it is alway related to a resource event (thus for primary / custom resource). In that way avoiding that state is created without a primary resource.
Signed-off-by: Attila Mészáros a_meszaros@apple.com