fix: RBAC typos in testsuite #2902
Conversation
xstefank
commented
Aug 18, 2025
|
pls reformat the code |
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes typos in YAML file references within the test suite, correcting "rback" to "rbac" (Role-Based Access Control) in multiple file paths.
- Corrects misspelled "rback" to "rbac" in YAML file references
- Updates 7 file path references across multiple test methods
- Ensures consistent naming convention for RBAC-related test resources
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| @@ -368,35 +368,35 @@ Operator startOperator( | |||
| } | |||
|
|
|||
| private void setNoConfigMapAccess() { | |||
| applyClusterRole("rback-test-no-configmap-access.yaml"); | |||
| applyClusterRole("rbac-test-no-configmap-access.yaml"); | |||
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void setNoCustomResourceAccess() { | ||
| applyClusterRole("rback-test-no-cr-access.yaml"); | ||
| applyClusterRole("rbac-test-no-cr-access.yaml"); |
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void setFullResourcesAccess() { | ||
| applyClusterRole("rback-test-full-access-role.yaml"); | ||
| applyClusterRole("rbac-test-full-access-role.yaml"); |
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| applyClusterRoleBinding(); | ||
| } | ||
|
|
||
| private void addRoleBindingsToTestNamespaces() { | ||
| var role = | ||
| ReconcilerUtils.loadYaml( | ||
| Role.class, this.getClass(), "rback-test-only-main-ns-access.yaml"); | ||
| Role.class, this.getClass(), "rbac-test-only-main-ns-access.yaml"); |
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| adminClient.resource(role).inNamespace(actualNamespace).createOrReplace(); | ||
| var roleBinding = | ||
| ReconcilerUtils.loadYaml( | ||
| RoleBinding.class, this.getClass(), "rback-test-only-main-ns-access-binding.yaml"); | ||
| RoleBinding.class, this.getClass(), "rbac-test-only-main-ns-access-binding.yaml"); |
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| adminClient.resource(roleBinding).inNamespace(actualNamespace).createOrReplace(); | ||
| } | ||
|
|
||
| private void applyClusterRoleBinding() { | ||
| var clusterRoleBinding = | ||
| ReconcilerUtils.loadYaml( | ||
| ClusterRoleBinding.class, this.getClass(), "rback-test-role-binding.yaml"); | ||
| ClusterRoleBinding.class, this.getClass(), "rbac-test-role-binding.yaml"); |
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
| @@ -418,7 +418,7 @@ private Namespace namespace(String name) { | |||
| private void removeClusterRoleBinding() { | |||
| var clusterRoleBinding = | |||
| ReconcilerUtils.loadYaml( | |||
| ClusterRoleBinding.class, this.getClass(), "rback-test-role-binding.yaml"); | |||
| ClusterRoleBinding.class, this.getClass(), "rbac-test-role-binding.yaml"); | |||
There was a problem hiding this comment.
The typo 'rback' has been corrected to 'rbac' in the file path reference.
Copilot uses AI. Check for mistakes.
Signed-off-by: xstefank <xstefank122@gmail.com>
|
funny note to myself: don't introduce formatting if you always forget to run the format plugin 🤦 |
|
I'd rather we don't use AI on this project. |
Yeah, let's have a discussion about that, either on community meeting or discussion on github |