🌱 Makefile: add test-upgrade-experimental-e2e #2151
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| @@ -90,9 +90,6 @@ EXPERIMENTAL_MANIFEST := ./manifests/experimental.yaml | |||
| EXPERIMENTAL_E2E_MANIFEST := ./manifests/experimental-e2e.yaml | |||
| CATALOGS_MANIFEST := ./manifests/default-catalogs.yaml | |||
|
|
|||
| # Manifest used by kind-deploy, which may be overridden by other targets | |||
| SOURCE_MANIFEST := $(STANDARD_MANIFEST) | |||
There was a problem hiding this comment.
Removing this is likely breaking things in multiple places (there are a number of failures)
| @@ -324,7 +337,6 @@ kind-load: $(KIND) #EXHELP Loads the currently constructed images into the KIND | |||
| $(CONTAINER_RUNTIME) save $(CATD_IMG) | $(KIND) load image-archive /dev/stdin --name $(KIND_CLUSTER_NAME) | |||
|
|
|||
| .PHONY: kind-deploy | |||
| kind-deploy: export MANIFEST := $(STANDARD_RELEASE_MANIFEST) | |||
There was a problem hiding this comment.
Deleting this causes two issues:
- You are redirecting into nothing on L331
- The
envsubstcommand doesn't have a value on L333
There was a problem hiding this comment.
It does not appear to be carried over from setting it in test-upgrade-e2e, etc.
|
Yeah, the "experimental-e2e" is using the standard manifest... which is plainly wrong... |
be4e87e to
b066e72
Compare
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
b066e72 to
1e615d8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2151 +/- ##
==========================================
- Coverage 72.79% 72.73% -0.06%
==========================================
Files 79 79
Lines 7340 7340
==========================================
- Hits 5343 5339 -4
- Misses 1651 1654 +3
- Partials 346 347 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Ok, I think I have it fixed up. Will double check that the correct manifests are being used for each job... |
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eebdcea
into
operator-framework:main
Description
Adds a make task and github workflow for running upgrade tests against the experimental e2e release. The intent is for this to be an "informing" job pre-merge, not a blocking job.
Reviewer Checklist