Skip to content

✨ ClusterExtensionConfig API #2163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

✨ ClusterExtensionConfig API #2163

wants to merge 5 commits into from
+437 −47

Conversation

perdasilva
Copy link
Contributor

@perdasilva perdasilva commented Aug 26, 2025 •
edited
Loading

Description

  • Adds the .spec.config stanza to the experimental ClusterExtension API as a discriminated union with a single type: "Inline"
  • Updates Single/OwnNamespace to take the watchNamespace configuration from .spec.config.inline
  • Updates the Single/OwnNamespace docs

Example

apiVersion: olm.operatorframework.io/v1
kind: ClusterExtension
metadata:
  name: test
spec:
  namespace: test
  serviceAccount:
    name: test-installer
  config:
    configType: Inline
    inline:
      watchNamespace: some-namespace
  source:
    sourceType: Catalog
    catalog:
      packageName: test-operator

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@perdasilva perdasilva changed the title Bundle config api ✨ Bundle config api Aug 26, 2025
@netlify Netlify
Copy link

netlify bot commented Aug 26, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit cb74b27
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/68ae018e0451100008e1c16a
😎 Deploy Preview https://deploy-preview-2163--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov Codecov
Copy link

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 76.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.70%. Comparing base (3b5e6fb) to head (cb74b27).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/v1/zz_generated.deepcopy.go 61.11% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
+ Coverage   72.67%   72.70%   +0.02%     
==========================================
  Files          79       79              
  Lines        7340     7370      +30     
==========================================
+ Hits         5334     5358      +24     
- Misses       1659     1665       +6     
  Partials      347      347
Flag Coverage Δ
e2e 44.18% <16.66%> (-0.08%) ⬇️
experimental-e2e 56.20% <60.00%> (+1.36%) ⬆️
unit 58.16% <40.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva perdasilva changed the title ✨ Bundle config api ✨ ClusterExtensionConfig API Aug 26, 2025
@perdasilva perdasilva force-pushed the bundle-config-api branch 2 times, most recently from 544b420 to 5dd6ee0 Compare August 26, 2025 14:29
@perdasilva perdasilva marked this pull request as ready for review August 26, 2025 14:31
@perdasilva perdasilva requested a review from a team as a code owner August 26, 2025 14:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2025
@openshift-ci openshift-ci bot requested review from anik120 and grokspawn August 26, 2025 14:31
joelanford
joelanford reviewed Aug 26, 2025
View reviewed changes
joelanford
joelanford reviewed Aug 26, 2025
View reviewed changes
joelanford
joelanford reviewed Aug 26, 2025
View reviewed changes
joelanford
joelanford reviewed Aug 26, 2025
View reviewed changes
tmshort
tmshort reviewed Aug 26, 2025
View reviewed changes
@perdasilva perdasilva force-pushed the bundle-config-api branch 2 times, most recently from 5c921e0 to a78b3a5 Compare August 26, 2025 15:16
joelanford
joelanford reviewed Aug 26, 2025
View reviewed changes
Per Goncalves da Silva added 3 commits August 26, 2025 18:15
Extend ClusterExtension API with .spec.config
bc1a19e 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Generate manifests
ac0290c 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Update docs
211786d 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@joelanford
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Aug 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2025
tmshort
tmshort reviewed Aug 26, 2025
View reviewed changes
api/v1/clusterextension_types.go
//
// config is optional. When not specified, the default configuration of the resolved bundle will be used.
//
// <opcon:experimental>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at that experimental tag...

@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
Per Goncalves da Silva added 2 commits August 26, 2025 20:48
Update applier to take watchNamespace configuration from the extension
3736eff 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
Add e2e test
cb74b27 
Signed-off-by: Per Goncalves da Silva <pegoncal@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2025
@tmshort
Copy link
Contributor

tmshort commented Aug 26, 2025 •
edited
Loading

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford left review comments

@tmshort tmshort tmshort left review comments

@anik120 anik120 Awaiting requested review from anik120

@grokspawn grokspawn Awaiting requested review from grokspawn

Assignees

@tmshort tmshort

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perdasilva @joelanford @tmshort