Fix invalid ConfigMap key translation #1742
Conversation
|
Hi @zimnx. Thanks for your PR. I'm waiting for a operator-framework member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
When generating ConfigMap keys from OLM bundle filenames, colons (`:`) were being replaced with tildes (`~`). However, `~` is not a valid character for ConfigMap keys, leading to errors like: ``` binaryData[scylladb~controller~aggregate-to-operator_rbac.authorization.k8s.io_v1_clusterrole.yaml]: Invalid value: "...": a valid config key must consist of alphanumeric characters, '-', '_' or '.' (regex: '[-._a-zA-Z0-9]+') ``` This commit fixes the issue by replacing `:` with hyphens (`-`) instead, which are allowed in ConfigMap keys. For example: * Before: `scylladb:controller:aggregate-to-operator...` → `scylladb~controller~aggregate-to-operator...` (invalid) * After: `scylladb:controller:aggregate-to-operator...` → `scylladb-controller-aggregate-to-operator...` (valid) This ensures all generated ConfigMap keys conform to Kubernetes naming requirements.
46a74a1 to
5813ca9
Compare
|
Kind reminder about this PR, thanks! |
|
/ok-to-test |
|
Thanks for the PR, @zimnx! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b5c503a
into
operator-framework:master
Description of the change:
When generating ConfigMap keys from OLM bundle filenames, colons (
:) were being replaced with tildes (~). However,~is not a valid character for ConfigMap keys, leading to errors like:This commit fixes the issue by replacing
:with hyphens (-) instead, which are allowed in ConfigMap keys. For example:scylladb:controller:aggregate-to-operator...→scylladb~controller~aggregate-to-operator...(invalid)scylladb:controller:aggregate-to-operator...→scylladb-controller-aggregate-to-operator...(valid)Motivation for the change:
This ensures all generated ConfigMap keys conform to Kubernetes naming requirements.
Reviewer Checklist
/docsCloses #1741