eliminate skipping same-Y.maxZ, which should only replace #1749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: grokspawn <jordan@nimblewidget.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
=========================================
Coverage ? 55.17%
=========================================
Files ? 136
Lines ? 15917
Branches ? 0
=========================================
Hits ? 8782
Misses ? 5982
Partials ? 1153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
camilamacedo86
approved these changes
Aug 20, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grokspawn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
a0e2cf8
into
operator-framework:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Don't generate a skips edge for Y.Z(max) to Y-1.Z(max).
Motivation for the change:
semver template expansion would include a skips link for Y.Z(max) for Y-1.Z(max), but we want Y transitions (for major-versioned channels) to replace the previous Y's Z(max). Unfortunately, due to OLMv0 graph mechanics, the skips results in discarding the replaces link, so the upgrade is broken. (For OLMv1, no graph contributions are ignored.)
Using a new version of opm which can highlight v0 upgrade graph semantics, this problem is clearer. Below picture shows limned in red every package whose contributions are ignored because of the presence of skips links, and every ignored link is ch
anged to a red, dashed line.
The updated flow will no longer generate a skip for a replaces edge, which renders the below graph, which has full mobility across the graph.
Reviewer Checklist
/docs