Skip to content

[FSSDK-11546] holdout + decision service impl. #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 25, 2025
Merged

[FSSDK-11546] holdout + decision service impl. #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
809d81f
[FSSDK-11546] decision service adjustmen
junaed-optimizely Aug 21, 2025
d262bdb
[FSSDK-11546] format adjustment
junaed-optimizely Aug 21, 2025
875cde2
[FSSDK-11546] type adjustment
junaed-optimizely Aug 21, 2025
d4de4e6
[FSSDK-11546] assertion adjustment
junaed-optimizely Aug 21, 2025
2cbe374
[FSSDK-11546] bucketer test addition + config issue adjustment
junaed-optimizely Aug 21, 2025
623df91
[FSSDK-11546] decision service holdout test addition
junaed-optimizely Aug 22, 2025
5fe6f61
[FSSDK-11546] decision service holdout test cleanup
junaed-optimizely Aug 22, 2025
68b7f22
[FSSDK-11546] user context test update
junaed-optimizely Aug 22, 2025
834caae
[FSSDK-11546] lint fix
junaed-optimizely Aug 22, 2025
34aa676
[FSSDK-11546] lint fix 2
junaed-optimizely Aug 22, 2025
633b7f5
[FSSDK-11546] lint fix 3
junaed-optimizely Aug 22, 2025
3337b64
[FSSDK-11546] irrelevant test file removal
junaed-optimizely Aug 22, 2025
5fb3872
[FSSDK-11546] experiment status "isRunning" logic simplified
junaed-optimizely Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion OptimizelySDK.Tests/Assertions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ public static void AreEqual(Experiment expected, Experiment actual)
Assert.AreEqual(expected.GroupId, actual.GroupId);
Assert.AreEqual(expected.GroupPolicy, actual.GroupPolicy);
Assert.AreEqual(expected.Id, actual.Id);
Assert.AreEqual(expected.IsExperimentRunning, actual.IsExperimentRunning);
Assert.AreEqual(expected.isRunning, actual.isRunning);
Assert.AreEqual(expected.IsInMutexGroup, actual.IsInMutexGroup);
Assert.AreEqual(expected.Key, actual.Key);
Assert.AreEqual(expected.LayerId, actual.LayerId);
Expand All @@ -500,13 +500,42 @@ public static void AreEqual(Experiment expected, Experiment actual)
AreEquivalent(expected.Variations, actual.Variations);
}

public static void AreEqual(ExperimentCore expected, ExperimentCore actual)
{
if (expected == null && actual == null)
{
return;
}

Assert.IsNotNull(expected, "Expected ExperimentCore should not be null");
Assert.IsNotNull(actual, "Actual ExperimentCore should not be null");

Assert.AreEqual(expected.AudienceConditions, actual.AudienceConditions);
Assert.AreEqual(expected.AudienceConditionsList, actual.AudienceConditionsList);
Assert.AreEqual(expected.AudienceConditionsString, actual.AudienceConditionsString);
AreEquivalent(expected.AudienceIds, actual.AudienceIds);
Assert.AreEqual(expected.AudienceIdsList, actual.AudienceIdsList);
Assert.AreEqual(expected.AudienceIdsString, actual.AudienceIdsString);
Assert.AreEqual(expected.Id, actual.Id);
Assert.AreEqual(expected.isRunning, actual.isRunning);
Assert.AreEqual(expected.Key, actual.Key);
Assert.AreEqual(expected.LayerId, actual.LayerId);
Assert.AreEqual(expected.Status, actual.Status);
AreEquivalent(expected.TrafficAllocation, actual.TrafficAllocation);
AreEquivalent(expected.VariationIdToVariationMap, actual.VariationIdToVariationMap);
AreEquivalent(expected.VariationKeyToVariationMap, actual.VariationKeyToVariationMap);
AreEquivalent(expected.Variations, actual.Variations);
}

#endregion Experiment

#region FeatureDecision

public static void AreEqual(FeatureDecision expected, FeatureDecision actual)
{
AreEqual(expected.Experiment, actual.Experiment);
AreEqual(expected.Variation, actual.Variation);
Assert.AreEqual(expected.Source, actual.Source);
}

#endregion FeatureDecision
Expand Down
Loading
Loading