[FSSDK-11547] Impression event + notification adjustment #387
+191
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements impression event tracking and notification support for holdout experiments in the Optimizely SDK. The change ensures that holdout decisions generate impression events and proper notification metadata, similar to how feature test decisions are handled.
- Extended impression event tracking to include holdout decisions alongside feature test decisions
- Added comprehensive test coverage for holdout notification content validation
- Added test coverage for impression event generation with holdout experiments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| OptimizelySDK/Optimizely.cs | Extended condition to include holdout decisions for impression event tracking |
| OptimizelySDK.Tests/OptimizelyUserContextHoldoutTest.cs | Added notification test for holdout decision content validation |
| OptimizelySDK.Tests/DecisionServiceHoldoutTest.cs | Added impression event tests for holdout experiments |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impression event + notification adjustment
Test plan
Tests have been added to assert the change
Issues
FSSDK-11547