add json encoding validation (#399)

Mat001 · web-flow · commit 9a010566e221 · 2022-08-15T10:49:12.000-07:00
diff --git a/optimizely/odp/zaius_graphql_api_manager.py b/optimizely/odp/zaius_graphql_api_manager.py
@@ -131,15 +131,21 @@ def fetch_segments(self, api_key: str, api_host: str, user_key: str,
                            'x-api-key': str(api_key)}
 
         segments_filter = self.make_subset_filter(segments_to_check)
-        payload_dict = {
+        query = {
             'query': 'query {customer(' + str(user_key) + ': "' + str(user_value) + '") '
             '{audiences' + segments_filter + ' {edges {node {name state}}}}}'
         }
 
+        try:
+            payload_dict = json.dumps(query)
+        except TypeError as err:
+            self.logger.error(Errors.FETCH_SEGMENTS_FAILED.format(err))
+            return None
+
         try:
             response = requests.post(url=url,
                                      headers=request_headers,
-                                     data=json.dumps(payload_dict),
+                                     data=payload_dict,
                                      timeout=OdpGraphQLApiConfig.REQUEST_TIMEOUT)
 
             response.raise_for_status()
@@ -166,7 +172,7 @@ def fetch_segments(self, api_key: str, api_host: str, user_key: str,
                 return None
 
             if error_class == 'InvalidIdentifierException':
-                self.logger.error(Errors.INVALID_SEGMENT_IDENTIFIER)
+                self.logger.warning(Errors.INVALID_SEGMENT_IDENTIFIER)
                 return None
             else:
                 self.logger.error(Errors.FETCH_SEGMENTS_FAILED.format(error_class))
diff --git a/tests/test_odp_zaius_graphql_api_manager.py b/tests/test_odp_zaius_graphql_api_manager.py
@@ -122,7 +122,7 @@ def test_fetch_qualified_segments__invalid_identifier(self):
                                segments_to_check=[])
 
         mock_request_post.assert_called_once()
-        mock_logger.error.assert_called_once_with('Audience segments fetch failed (invalid identifier).')
+        mock_logger.warning.assert_called_once_with('Audience segments fetch failed (invalid identifier).')
 
     def test_fetch_qualified_segments__other_exception(self):
         with mock.patch('requests.post') as mock_request_post, \
