Skip to content

feat: add json encoding validation #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2022
Merged

feat: add json encoding validation #399

merged 1 commit into from
Aug 15, 2022

Conversation

Mat001
Copy link
Contributor

@Mat001 Mat001 commented Aug 15, 2022

Summary

Test plan

  • adjusted unit tests
  • FSC tests

@Mat001 Mat001 requested a review from a team as a code owner August 15, 2022 07:32
andrewleap-optimizely
andrewleap-optimizely approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@andrewleap-optimizely andrewleap-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mat001 Mat001 merged commit 9a01056 into master Aug 15, 2022
@Mat001 Mat001 deleted the mpirnovar/graphql_json_encoding_validation branch August 15, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewleap-optimizely andrewleap-optimizely andrewleap-optimizely approved these changes

@jaeopt jaeopt Awaiting requested review from jaeopt

Assignees

@Mat001 Mat001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mat001 @andrewleap-optimizely