Skip to content

[FSSDK-11690] chore: remove layer id from holdout #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FSSDK-11690] chore: remove layer id from holdout #604

wants to merge 1 commit into from
+4 −27

Conversation

muzahidul-opti
Copy link
Contributor

Summary

  • Since the layer id is not required for HO, it has been removed.

Test plan

  • All existing test cases should be passed

Issues

  • FSSDK-11690

@muzahidul-opti muzahidul-opti marked this pull request as ready for review July 14, 2025 17:37
@muzahidul-opti muzahidul-opti requested a review from jaeopt July 14, 2025 17:38
jaeopt
jaeopt requested changes Jul 14, 2025
View reviewed changes
Sources/Data Model/Holdout.swift
lhs.variations == rhs.variations &&
lhs.layerId == rhs.layerId &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't remove this line?

Sources/Data Model/Holdout.swift
Comment on lines +44 to +45
// Not necessary for HO
var layerId: String = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@muzahidul-opti muzahidul-opti

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@muzahidul-opti @jaeopt