TST: Remove match= in test_setitem_invalid to avoid PytestWarning #61577
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Jun 6, 2025
datapythonista
approved these changes
Jun 9, 2025
There was a problem hiding this comment.
Personally I'd just remove the match parameter (unless we have a check to make sure it exists).
But either way this looks good, thanks for taking care of it @iabhi4.
I tend to agree with @datapythonista, unless there is a specific check that we are looking for and in this case it does not appear to be, I would leave out the |
|
@mroeschke I think the changes you requested have been implemented, this should be ready to merge |
mroeschke
approved these changes
Jun 13, 2025
|
Thanks @iabhi4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test only change - This PR removes the use of
match=""intest_setitem_invalidwithinbase/setitem.py.Using an empty string as a match pattern triggers a
PytestWarningin newer versions of pytest, so thematchargument has been removed since the message was not being validated