DEP: update python-calamine to 0.3.2 #61606
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It'd be good to either link an existing issue, or to write a description, so we can understand why we should merge this. |
|
@datapythonista Thanks for the reminder! I’ve now added the issue link for clarity. Since this is my first PR involving a package version bump, I wanted to ask:
Thanks! |
|
Thanks for the context. This looks reasonable. In general we support dependencies that are two years old. Given there is a bug, I guess it can make sense to require a version that is newer than that. @mroeschke @rhshadrach do you have an opinion on whether it's more important to be compatible with older versions one of the libraries to read Excel, or to prevent a bug it has? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.This PR updates the calamine engine dependency to version
0.3.2, which includes the upstream fix for leading-zero truncation in VLOOKUP-derived Excel cells.