Move chained assignment detection to cython for Python 3.14 compat #62070
+69
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pandas/_libs/internals.pyx
Outdated
| # @cython.auto_pickle(False) | ||
| cdef class SetitemMixin: | ||
|
|
||
| def __setitem__(self, key, value): |
There was a problem hiding this comment.
can this be made cdef? small perf improvement i think. downside is i think it becomes harder for subclassers who want to override it. But after this PR, they should be overriding _setitem instead
There was a problem hiding this comment.
No, special (dunder) methods need to be specified as def (That's also what I would have expected since this method should be callable from python, but even cpdef gives a cython compilation error "Special methods must be declared with 'def', not 'cdef'")
|
Some commented-out code needs to be removed, otherwise looks nice |
66cd359 to
efea93f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft exploring a solution for #61368