Skip to content

An error handling for division by zero was added by throwing IllegalA… #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

An error handling for division by zero was added by throwing IllegalA… #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .project
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,15 @@
<natures>
<nature>org.eclipse.jdt.core.javanature</nature>
</natures>
<filteredResources>
<filter>
<id>1730486517114</id>
<name></name>
<type>30</type>
<matcher>
<id>org.eclipse.core.resources.regexFilterMatcher</id>
<arguments>node_modules|\.git|__CREATED_BY_JAVA_LANGUAGE_SERVER__</arguments>
</matcher>
</filter>
</filteredResources>
</projectDescription>
33 changes: 30 additions & 3 deletions src/com/jwetherell/algorithms/mathematics/Division.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,35 +3,49 @@
public class Division {

public static final long division(int a, int b) {
if (b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting user the denominator is zero.

}

long result = ((long) a) / ((long) b);

return result;
}

public static final long divisionUsingLoop(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if denominator is 0 before the rest of the division process is complete.

}

long temp = absA;
long result = 0;
while (temp >= 0) {
temp -= absB;
if (temp >= 0)
result++;
}
}

return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result;
}

public static final long divisionUsingRecursion(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if (b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if denominator is 0 before the rest of the division process is complete.

}

long result = 1;
int diff = absA - absB;
if (diff > 0 && diff <= 1) {
return result;
} else if (diff < 0) {
} else if (diff < 0) {
return 0;
}
}

result += divisionUsingRecursion(diff, absB);
return (a > 0 && b > 0 || a < 0 && b < 0) ? result : -result;
Expand All @@ -41,6 +55,10 @@ public static final long divisionUsingMultiplication(int a, int b) {
int absA = Math.abs(a);
int absB = Math.abs(b);

if(b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if denominator is 0 before the rest of the division process is complete.

}

int temp = absB;
int counter = 0;
while (temp <= absA) {
Expand All @@ -59,6 +77,10 @@ public static final long divisionUsingShift(int a, int b) {
int absB = Math.abs(b);
int tempA, tempB, counter;

if(b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if denominator is 0 before the rest of the division process is complete.

}

long result = 0L;
while (absA >= absB) {
tempA = absA >> 1; // Right shift "a"
Expand All @@ -78,6 +100,11 @@ public static final long divisionUsingShift(int a, int b) {
public static final long divisionUsingLogs(int a, int b) {
long absA = Math.abs(a);
long absB = Math.abs(b);

if(b == 0){
throw now IllegalArgumentException ("Denominator is 0.");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checks if denominator is 0 before the rest of the division process is complete.

}

double logBase10A = Math.log10(absA);
double logBase10B = Math.log10(absB);
double powOf10 = Math.pow(10, (logBase10A - logBase10B));
Expand Down