Skip to content

Reduce bytes in parse function #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2025
Merged

Reduce bytes in parse function #395

merged 1 commit into from
Aug 18, 2025

Conversation

blakeembrey
Copy link
Member

Shaves ~2.5% (1.95kb -> 1.9kb) of build output size by further simplifying the merged code between the lexer and parser started in #363.

@blakeembrey blakeembrey requested a review from a team August 7, 2025 21:18
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.17%. Comparing base (687a9bb) to head (02da6a9).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
- Coverage   99.21%   99.17%   -0.04%     
==========================================
  Files           1        1              
  Lines         381      364      -17     
  Branches      132      130       -2     
==========================================
- Hits          378      361      -17     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@ctcpip ctcpip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this improves perf a bit as well

Base automatically changed from be/debug-original-path to master August 18, 2025 18:02
@blakeembrey blakeembrey force-pushed the be/trim-parser-bytes branch from 8891e77 to 02da6a9 Compare August 18, 2025 18:39
@blakeembrey blakeembrey merged commit 4a91505 into master Aug 18, 2025
9 checks passed
@blakeembrey blakeembrey deleted the be/trim-parser-bytes branch August 18, 2025 23:34
@blakeembrey
Copy link
Member Author

looks like this improves perf a bit as well

Just a tiny bit, but hopefully no one is parsing that much to matter anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants