Skip to content

Add custom error class #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Add custom error class #398

merged 2 commits into from
Aug 19, 2025

Conversation

blakeembrey
Copy link
Member

Follow up from #363 (comment). Found a solution that adds originalPath to the errors in a way that doesn't add to stack size, increases the build by only 0.01kb (half the original test in my comment), and adds originalPath as a property to all the errors.

@blakeembrey blakeembrey requested review from wesleytodd and a team August 19, 2025 00:53
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (265a2a7) to head (667d91f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          379       378    -1     
  Branches       136       136           
=========================================
- Hits           379       378    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blakeembrey blakeembrey changed the title Add custom ParseError class Add custom error class Aug 19, 2025
@blakeembrey blakeembrey merged commit 2a7f2a4 into master Aug 19, 2025
8 checks passed
@blakeembrey blakeembrey deleted the be/add-parse-error branch August 19, 2025 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants