Remove unused graph rewriting functionality #1595
Merged
+57
−534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
396d506 to
5bfbcbe
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (85.71%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1595 +/- ##
==========================================
+ Coverage 81.54% 81.71% +0.17%
==========================================
Files 230 230
Lines 53136 52924 -212
Branches 9448 9402 -46
==========================================
- Hits 43329 43248 -81
+ Misses 7370 7244 -126
+ Partials 2437 2432 -5
🚀 New features to boost your workflow:
|
jessegrabowski
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #1592
This PR removes several rewriting functionality that was not used anywhere besides the tests. They don't really do anything that would be hard to implement if someone needed it.
On the plus side, it provides less ways of doing the same thing, which should reduce confusion.
I left the unused
pre_greedy_node_rewriterwhich used to be used in the ScanSaveMemory to try and curb the crazy subtensor graph that it generates (discussed in #112). Until we address that issue I'll let it stay for reference.📚 Documentation preview 📚: https://pytensor--1595.org.readthedocs.build/en/1595/