Skip to content

Check commit count against upstream #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

webknjaz
Copy link
Contributor

@webknjaz webknjaz commented Feb 10, 2025

Previously, the git log command would run against an unresolved branch reference, which might point to the wrong thing locally. This patch makes it more predictable by specifying the exact remote branch.

Fixes #124
Fixes #155

Previously, the `git log` command would run against an unresolved
branch reference which might point to the wrong thing locally. This
patch makes it more predictable by specifying the exact remote branch.

Fixes python#155.
@koyuki7w
Copy link

also related: gh-124

@AA-Turner AA-Turner changed the title 🚑 Check commit number against upstream branch Check commit count against upstream Mar 14, 2025
@python-cla-bot
Copy link

python-cla-bot bot commented Apr 6, 2025

All commit authors signed the Contributor License Agreement.

CLA signed

@webknjaz
Copy link
Contributor Author

@hugovk mind getting this in? I just encountered this again...

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been running this version locally for a few weeks and haven't run into any issues, so let's go with it. Thanks!

@hugovk hugovk merged commit cdae289 into python:main Aug 15, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from 🫸In review🫷 to 🌈 Done 🦄 in 📅 Procrastinating in public Aug 15, 2025
@hugovk
Copy link
Member

hugovk commented Aug 21, 2025

This has been released in Cherry Picker 2.6.0: https://github.com/python/cherry-picker/releases/tag/cherry-picker-v2.6.0 🍒🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants