Skip to content

TypeError: '<' not supported between instances of 'NoneType' and 'int' raised during call to email.message_from_file #134151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gabe-sherman opened this issue May 17, 2025 · 4 comments
Closed

TypeError: '<' not supported between instances of 'NoneType' and 'int' raised during call to email.message_from_file #134151

gabe-sherman opened this issue May 17, 2025 · 4 comments
Labels
stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error

Comments

@gabe-sherman
Copy link

gabe-sherman commented May 17, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

During fuzzing of Python standard libraries, the following code snippet causes a TypeError with the following message: TypeError: '<' not supported between instances of 'NoneType' and 'int'. This occurs in the decode_params function at line 419 in email/utils.py.

import sys
import io
import email
d =  io.StringIO(open(sys.argv[1], "r").read())
email.message_from_file(d)

POC File:

https://github.com/FuturesLab/POC/blob/main/py-email/poc-02

Exception Trace

Traceback (most recent call last):
  File "rep.py", line 5, in <module>
    email.message_from_file(d)
  File "/usr/lib/python3.12/email/__init__.py", line 53, in message_from_file
    return Parser(*args, **kws).parse(fp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/parser.py", line 54, in parse
    return feedparser.close()
           ^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/feedparser.py", line 185, in close
    self._call_parse()
  File "/usr/lib/python3.12/email/feedparser.py", line 178, in _call_parse
    self._parse()
  File "/usr/lib/python3.12/email/feedparser.py", line 304, in _parsegen
    boundary = self._cur.get_boundary()
               ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/message.py", line 861, in get_boundary
    boundary = self.get_param('boundary', missing)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/message.py", line 725, in get_param
    for k, v in self._get_params_preserve(failobj, header):
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/message.py", line 674, in _get_params_preserve
    params = utils.decode_params(params)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/email/utils.py", line 419, in decode_params
    continuations.sort()
TypeError: '<' not supported between instances of 'NoneType' and 'int'

CPython versions tested on:

3.12, 3.11, 3.10, 3.9

Operating systems tested on:

Linux

Linked PRs
@gabe-sherman gabe-sherman added the type-bug An unexpected behavior, bug, or error label May 17, 2025
@picnixz picnixz added stdlib Python modules in the Lib dir topic-email labels May 17, 2025
@picnixz
Copy link
Member

picnixz commented May 18, 2025

@bitdancer If possilbe, could you also have a look at:

TiA.

@bitdancer
Copy link
Member

This issue is in the old code, not the new API. If someone feels like fixing it I'll review, but I'm not going to fix this one myself. I'll look at the other issues presently, which are in the new API.

@bedevere-app bedevere-app bot mentioned this issue May 26, 2025
Merged
@zangjiucheng
Copy link
Contributor

Hello everyone,

I am surprised to discover that this is a legend code craft from 17 years ago. I am uncertain of the extent to which it could be beneficial to fix it, as we have already received a new API. However, I would appreciate it if you could take a look at it, @bitdancer.

Please let me know if you believe it is appropriate to merge this into the main branch :), thanks!

picnixz pushed a commit that referenced this issue Jun 8, 2025
@zangjiucheng
gh-134151 Fix TypeError in email.utils.decode_params when sorting…
bcb6b45 
… RFC 2231 continuations (#134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 8, 2025
@zangjiucheng @miss-islington
pythongh-134151 Fix TypeError in email.utils.decode_params when s…
be338b2 
…orting RFC 2231 continuations (pythonGH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 8, 2025
@zangjiucheng @miss-islington
pythongh-134151 Fix TypeError in email.utils.decode_params when s…
b346f6d 
…orting RFC 2231 continuations (pythonGH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
This was referenced Jun 8, 2025
Merged
Merged
picnixz pushed a commit that referenced this issue Jun 8, 2025
@miss-islington @zangjiucheng
[3.13] gh-134151 Fix TypeError in email.utils.decode_params when …
e5d1771 
…sorting RFC 2231 continuations (GH-134687) (#135248)

gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
picnixz pushed a commit that referenced this issue Jun 8, 2025
@miss-islington @zangjiucheng
[3.14] gh-134151 Fix TypeError in email.utils.decode_params when …
85efa77 
…sorting RFC 2231 continuations (GH-134687) (#135247)

gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687)

- Fix sorting logic in `email.utils.decode_params` to handle None values.
- Update tests for RFC 2231 continuation sorting.
(cherry picked from commit bcb6b45)

Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
@bitdancer
Copy link
Member

Thanks @zangjiucheng for the fix, and @picnixz for the additional review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir topic-email type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bitdancer @picnixz @gabe-sherman @zangjiucheng