gh-134151 Fix TypeError in email.utils.decode_params() when sorting RFC 2231 continuations #134687
Conversation
…ntinuations on Python 3 and add corresponding test case
…d update tests for continuation sorting
Misc/NEWS.d/next/Library/2025-05-25-23-23-05.gh-issue-134151.13Wwsb.rst
Outdated
Show resolved
Hide resolved
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @bitdancer: please review the changes made to this pull request. |
Misc/NEWS.d/next/Library/2025-05-25-23-23-05.gh-issue-134151.13Wwsb.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Library/2025-05-25-23-23-05.gh-issue-134151.13Wwsb.rst
Outdated
Show resolved
Hide resolved
|
I'll merge this tomorrow if it's not already merged; I'm a bit too tired for writing a commit message now :') |
|
Thanks for your guys’ reviews! @picnixz, take care and enjoy your night :D
|
|
Thanks @zangjiucheng for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…orting RFC 2231 continuations (pythonGH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
|
GH-135247 is a backport of this pull request to the 3.14 branch. |
…orting RFC 2231 continuations (pythonGH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
|
GH-135248 is a backport of this pull request to the 3.13 branch. |
…sorting RFC 2231 continuations (GH-134687) (#135248) gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
…sorting RFC 2231 continuations (GH-134687) (#135247) gh-134151 Fix `TypeError` in `email.utils.decode_params` when sorting RFC 2231 continuations (GH-134687) - Fix sorting logic in `email.utils.decode_params` to handle None values. - Update tests for RFC 2231 continuation sorting. (cherry picked from commit bcb6b45) Co-authored-by: Jiucheng(Oliver) <git.jiucheng@gmail.com>
TypeError: '<' not supported between instances of 'NoneType' and 'int'raised during call toemail.message_from_file#134151