Skip to content

argparse: Unexpanded replacements in "unknown action" exception #134970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mgorny opened this issue May 31, 2025 · 0 comments
Closed

argparse: Unexpanded replacements in "unknown action" exception #134970

mgorny opened this issue May 31, 2025 · 0 comments
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@mgorny
Copy link
Contributor

mgorny commented May 31, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

cpython/Lib/argparse.py

Lines 1536 to 1537 in ad39f01

if not callable(action_class):
raise ValueError('unknown action {action_class!r}')

There is a missing f there, so the replacements don't happen. Noticed accidentally because it broke snakeoil's test suite.

CPython versions tested on:

3.14, CPython main branch

Operating systems tested on:

Linux

Linked PRs
@mgorny mgorny added the type-bug An unexpected behavior, bug, or error label May 31, 2025
mgorny added a commit to mgorny/cpython that referenced this issue May 31, 2025
@mgorny
pythongh-134970: Fix exception message in argparse module
fb863c8 
Fix the "unknown action" exception
in `argparse.ArgumentParser.add_argument_group()` to correctly replace
the action class.
@bedevere-app bedevere-app bot mentioned this issue May 31, 2025
Merged
@ZeroIntensity ZeroIntensity added stdlib Python modules in the Lib dir 3.13 bugs and security fixes 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 31, 2025
serhiy-storchaka pushed a commit that referenced this issue Jun 1, 2025
@mgorny
gh-134970: Fix exception message in argparse module (GH-134971)
965c480 
Fix the "unknown action" exception in argparse.ArgumentParser.add_argument_group()
to correctly replace the action class.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 1, 2025
@mgorny @miss-islington
pythongh-134970: Fix exception message in argparse module (pythonGH-1…
2dbeeb7 
…34971)

Fix the "unknown action" exception in argparse.ArgumentParser.add_argument_group()
to correctly replace the action class.
(cherry picked from commit 965c480)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
@bedevere-app bedevere-app bot mentioned this issue Jun 1, 2025
Merged
@serhiy-storchaka serhiy-storchaka removed the 3.13 bugs and security fixes label Jun 1, 2025
serhiy-storchaka pushed a commit that referenced this issue Jun 1, 2025
@miss-islington @mgorny
[3.14] gh-134970: Fix exception message in argparse module (GH-134971) (
df7247a 
GH-134991)

Fix the "unknown action" exception in argparse.ArgumentParser.add_argument_group()
to correctly replace the action class.
(cherry picked from commit 965c480)

Co-authored-by: Michał Górny <mgorny@gentoo.org>
@github-project-automation github-project-automation bot moved this to Doc issues in Argparse issues Jun 2, 2025
@danielhollas danielhollas mentioned this issue Jun 3, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
Projects
Argparse issues
Status: Doc issues
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgorny @serhiy-storchaka @ZeroIntensity