GH-127682: Only call __iter__ once in generator expressions.
#132351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iritkatriel
approved these changes
Apr 10, 2025
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @markshannon, I could not cleanly backport this to |
markshannon
added a commit
to faster-cpython/cpython
that referenced
this pull request
Apr 11, 2025
|
Do you need to bump the magic number here? I forgot if compiler-only changes need that. |
|
I don’t think so, since the bytecode format and behavior is unchanged. |
markshannon
added a commit
that referenced
this pull request
Apr 29, 2025
This was referenced May 25, 2025
| @@ -123,15 +123,6 @@ | |||
| >>> list(g) | |||
| [0, 1, 4, 9, 16, 25, 36, 49, 64, 81] | |||
| Verify that the outermost for-expression makes an immediate check | |||
|
If this change of behaviour is actually desirable (which may require some further discussion to establish), it should be mentioned in the What's New documentation. |
|
See #135171 (comment) for a more detailed analysis I'll make a PR for the what's new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the extra
GET_ITERinstruction emitted when creating a generator expression.This:
__iter__method to be used in generator expressions, as they were up until 3.12.