Skip to content

[3.13] GH-127682: Backport GH-132351 #132384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

[3.13] GH-127682: Backport GH-132351 #132384

merged 1 commit into from
Apr 29, 2025

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Apr 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 11, 2025
Closed
@markshannon markshannon merged commit 132bdf6 into python:3.13 Apr 29, 2025
40 checks passed
@Roman513 Roman513 mentioned this pull request Jun 5, 2025
Open
@Yhg1s
Copy link
Member

Yhg1s commented Jun 5, 2025

Looks like this changes behaviour in a couple of subtle ways (see #135171) and it's not suitable for backport. I'm not sure if the changed behaviour is suitable for 3.14, but I'll leave that to @hugovk to investigate ;p

@Roman513
Copy link

Roman513 commented Jun 5, 2025 •
edited
Loading

Maybe it worth to check later if alternative closed PR from @efimov-mikhail has better handling of this for such cases: #126408 - at least for 3.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markshannon @Yhg1s @Roman513 @iritkatriel